hana-branch commented 1 year ago

Pull Request Template

Description

To improve the Journeys Accessibility Audit WCAG 2.1, changed that the visual label of a CTA is the same as the programmatical name.

Fixes # BUX-1856

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Unit test
[X] Integration test

JS Budget Check

Please mention the size in kb before and after this PR

Files	Before	After
dist/build.js.	164 KB	164 KB
dist/build.min.js	74 KB	74 KB

Checklist:

[ ] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[ ] I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

JagadeeshKaricherla-branch commented 1 year ago

@hana-branch : aria-label can be set inside addDynamicCtaText method itself. Dont need to repeat the code in a new method.

journeys_utils.addDynamicCtaText = function (iframe, ctaText) {
    var doc = iframe.contentWindow.document;
    if (doc && doc.getElementById('branch-mobile-action')) {
        var mobileAction = doc.getElementById('branch-mobile-action');
        mobileAction.innerHTML = ctaText;
        mobileAction.setAttribute('aria-label', ctaText);
    }
}