BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 100 forks source link

[patch] upgrade closure-compiler to latest #870

Closed branch-nchoudry closed 1 year ago

branch-nchoudry commented 1 year ago

Description

The current version of google-closure-compiler 20220601.0.0 is outdated and vulnerable to CVE-2022-25647.

Change release note - https://github.com/google/closure-compiler/releases/tag/v20230206

Fixes # (issue) Upgrade google-closure-compiler to 20230206.0.0 to patch CVE-2022-25647.

google-closure-deps: ^20220502.0.0 to ^20230103.0.0 and google-closure-library: ^20220502.0.0 to ^20230103.0.0

Type of change

Please delete options that are not relevant. -

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR - TBD

Files Before After
dist/build.js. 164KB 160KB
dist/build.min.js 74KB 74KB

Checklist:

TBD

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

branch-nchoudry commented 1 year ago

FYI - Request from firstcard.app

JagadeeshKaricherla-branch commented 1 year ago

LGTM

dmelo commented 1 year ago

@branch-nchoudry , do you know when this is planned to be released?

branch-nchoudry commented 1 year ago

@branch-nchoudry , do you know when this is planned to be released?

We will release these changes next week. Thanks!

dmelo commented 1 year ago

@branch-nchoudry , any update on publishing this PR?

dmelo commented 1 year ago

Hi @branch-nchoudry. Do you have any updates?

JagadeeshKaricherla-branch commented 1 year ago

We are currently testing these changes and will make a release post testing.

dmelo commented 1 year ago

Hi @JagadeeshKaricherla-branch and @branch-nchoudry , any updates about when this will be released?

JagadeeshKaricherla-branch commented 1 year ago

This is included in our latest release.