Closed yli-branch closed 1 year ago
@JagadeeshKaricherla-branch Will you provide guidance on whether this PR passes the styling requirements for the web-sdk code repo?
is it normal to merge PRs without approvals in this repo...?
@mack-branch : Jason and I had a zoom session for code review and some refactors (https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/888) merged into this branch before this branch is merged to master.
@mack-branch : Jason and I had a zoom session for code review and some refactors (#888) merged into this branch before this branch is merged to master.
ok but this PR #885 was merged into master without approval
just want to make sure we arent making this a habit
Description
Fixes bug in converting percentage bannerHeight to pixel value
Jira: https://branch.atlassian.net/browse/INTENG-18040
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.