[patch] [INTENG-18040] Fixes bug in converting percentage bannerHeight

yli-branch commented 1 year ago

Description

Fixes bug in converting percentage bannerHeight to pixel value

Jira: https://branch.atlassian.net/browse/INTENG-18040

Type of change

Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[x] Unit test
[ ] Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files	Before	After
dist/build.js.
dist/build.min.js

Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

yli-branch commented 1 year ago

@JagadeeshKaricherla-branch Will you provide guidance on whether this PR passes the styling requirements for the web-sdk code repo?

mack-branch commented 1 year ago

is it normal to merge PRs without approvals in this repo...?

JagadeeshKaricherla-branch commented 1 year ago

@mack-branch : Jason and I had a zoom session for code review and some refactors (https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/888) merged into this branch before this branch is merged to master.

mack-branch commented 1 year ago

@mack-branch : Jason and I had a zoom session for code review and some refactors (#888) merged into this branch before this branch is merged to master.

ok but this PR #885 was merged into master without approval

mack-branch commented 1 year ago

just want to make sure we arent making this a habit

BranchMetrics / web-branch-deep-linking-attribution