Closed hana-branch closed 1 year ago
build.js, build.min.js changes look incorrect and breaking.
You can either generate them correctly using make release
or totally remove them from the PR.
@JagadeeshKaricherla-branch make release
does not change anything and then I try to copy and current master to dist file but it still shows a difference. can you please suggest to me how can I handle this?
@hana-branch no need to push build.js, build.min.js
@JagadeeshKaricherla-branch I generated the new PR here: https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/899 . Please review that PR?
Pull Request Template
Description
change not to focus the entire banner div box so yellow box-shadow does not around the banner
Fixes # https://branch.atlassian.net/browse/BUX-2354
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.