BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

[minor] BUX-2354 change not to focus entire banner div box #898

Closed hana-branch closed 1 year ago

hana-branch commented 1 year ago

Pull Request Template

Description

change not to focus the entire banner div box so yellow box-shadow does not around the banner

Fixes # https://branch.atlassian.net/browse/BUX-2354

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js. 164 KB 164 KB
dist/build.min.js 74 KB 74 KB

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

JagadeeshKaricherla-branch commented 1 year ago

build.js, build.min.js changes look incorrect and breaking.

You can either generate them correctly using make release or totally remove them from the PR.

hana-branch commented 1 year ago

@JagadeeshKaricherla-branch make release does not change anything and then I try to copy and current master to dist file but it still shows a difference. can you please suggest to me how can I handle this?

JagadeeshKaricherla-branch commented 1 year ago

@hana-branch no need to push build.js, build.min.js

hana-branch commented 1 year ago

@JagadeeshKaricherla-branch I generated the new PR here: https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/899 . Please review that PR?