BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

Revert back the change #900

Closed hana-branch closed 1 year ago

hana-branch commented 1 year ago

Description

Revert back the PR : https://github.com/BranchMetrics/web-branch-deep-linking-attribution/pull/899

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

JagadeeshKaricherla-branch commented 1 year ago

@hana-branch what’s the reason for revert ?

hana-branch commented 1 year ago

after investigating, it seems that we need to add \n *:focus {\n outline:\n none !important;\n } \n to branch view style and it works when I tested locally with the few branch views. For this, we actually need the branch view record update in staging DB. You do not need to merge this change to the master yet. I will let you know once the db change is done and will work as expected for QA testing as well.

hana-branch commented 1 year ago

@JagadeeshKaricherla-branch could you merge this to the master?