BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

fix(core): fix issue with closure minification #910

Closed JagadeeshKaricherla-branch closed 1 year ago

JagadeeshKaricherla-branch commented 1 year ago

fix issue with closure minification where properties added with dot notation are left with a undefined reference.This has affected the referringLinkExpiry property added with dot notation resulting in a bug where referringLinkExpiry is not saved in browser storage.

Screen Shot 2023-06-28 at 2 10 02 PM

Pull Request Template

Description

Replaced dot notation with square brackets notation

Fixes # (issue) : SDK-1996

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 1 year ago

Test Results

111 tests   104 :heavy_check_mark:  1m 26s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit 3c8aa066.

:recycle: This comment has been updated with latest results.