BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

fix(SDK-2037): remove session_id check to determine when to call v1/open #919

Closed JagadeeshKaricherla-branch closed 9 months ago

JagadeeshKaricherla-branch commented 11 months ago

remove session_id check to determine when to call v1/open

Pull Request Template

Description

We no longer need to check for session_id inside browser storage to determine when to call v1/open. just checking the presence of sessionData object is enough

Fixes # (issue) : SDK-2037

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 11 months ago

Test Results

112 tests   105 :heavy_check_mark:  1m 34s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit 060c87c7.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 11 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@4def7b1). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #919   +/-   ##
=========================================
  Coverage          ?   24.63%           
=========================================
  Files             ?       15           
  Lines             ?     2318           
  Branches          ?        0           
=========================================
  Hits              ?      571           
  Misses            ?     1747           
  Partials          ?        0           
gdeluna-branch commented 10 months ago

Just to confirm, in the case of init failure, there's no sessionData object right?