Closed JagadeeshKaricherla-branch closed 9 months ago
112 tests 105 :heavy_check_mark: 1m 34s :stopwatch: 1 suites 7 :zzz: 1 files 0 :x:
Results for commit 060c87c7.
:recycle: This comment has been updated with latest results.
:exclamation: No coverage uploaded for pull request base (
master@4def7b1
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #919 +/- ##
=========================================
Coverage ? 24.63%
=========================================
Files ? 15
Lines ? 2318
Branches ? 0
=========================================
Hits ? 571
Misses ? 1747
Partials ? 0
Just to confirm, in the case of init failure, there's no sessionData
object right?
remove session_id check to determine when to call v1/open
Pull Request Template
Description
We no longer need to check for session_id inside browser storage to determine when to call v1/open. just checking the presence of sessionData object is enough
Fixes # (issue) : SDK-2037
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
JS Budget Check
Please mention the size in kb before abd after this PR
Checklist:
Mentions:
List the person or team responsible for reviewing proposed changes.
cc @BranchMetrics/saas-sdk-devs for visibility.