BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

fix(journeys): remove audience pageview call #938

Open JagadeeshKaricherla-branch opened 9 months ago

JagadeeshKaricherla-branch commented 9 months ago

remove audience pageview call

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 9 months ago

Test Results

112 tests   105 :heavy_check_mark:  56s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit a320e2cf.

ahmednawar commented 9 months ago

can you add some explanation in the PR description?

codecov[bot] commented 9 months ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d39e439). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #938   +/-   ##
=========================================
  Coverage          ?   24.67%           
=========================================
  Files             ?       15           
  Lines             ?     2310           
  Branches          ?        0           
=========================================
  Hits              ?      570           
  Misses            ?     1740           
  Partials          ?        0