BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

Feat(MLP-13) : Update journey display criterion to include desktop, rename mobileUserAgent to getPlatformByUserAgent #960

Closed JagadeeshKaricherla-branch closed 6 months ago

JagadeeshKaricherla-branch commented 7 months ago

Description

Fixes # (issue) : MLP-13

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 7 months ago

Test Results

123 tests   116 :heavy_check_mark:  46s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit 7ff34d0a.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@e8b2db5). Click here to learn what that means.

:exclamation: Current head 6fc5bbd differs from pull request most recent head 7ff34d0. Consider uploading reports for the commit 7ff34d0 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #960 +/- ## ========================================= Coverage ? 25.15% ========================================= Files ? 15 Lines ? 2326 Branches ? 0 ========================================= Hits ? 585 Misses ? 1741 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.