BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

Feature deprecation/banner #963

Closed JagadeeshKaricherla-branch closed 7 months ago

JagadeeshKaricherla-branch commented 7 months ago

Pull Request Template

Description

Add deprecation warning for Branch.banner method

Fixes # (issue) : SDK-2196

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 7 months ago

Test Results

114 tests   107 :heavy_check_mark:  44s :stopwatch:     1 suites      7 :zzz:     1 files        0 :x:

Results for commit e165a772.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (master@c28c20c). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #963 +/- ## ========================================= Coverage ? 25.01% ========================================= Files ? 15 Lines ? 2323 Branches ? 0 ========================================= Hits ? 581 Misses ? 1742 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.