BranchMetrics / web-branch-deep-linking-attribution

The Branch Web SDK for deep linking and attribution. Once initialized, the Branch Web SDK allows you to create and share links with a banner (web only), over SMS, or your own methods by generating deep links. It also offers event tracking, access to referrals, and management of credits.
https://help.branch.io/developers-hub/docs/web-sdk-overview
MIT License
287 stars 101 forks source link

fix(journeys): prevent main inside body from taking total height of the overlay journeys #982

Closed JagadeeshKaricherla-branch closed 4 months ago

JagadeeshKaricherla-branch commented 5 months ago

Pull Request Template

Description

prevent main inside body from taking total height of the overlay journeys

Fixes # (issue) : MLP-13

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

JS Budget Check

Please mention the size in kb before abd after this PR

Files Before After
dist/build.js.
dist/build.min.js

Checklist:

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

github-actions[bot] commented 5 months ago

Test Results

127 tests  ±0   120 :white_check_mark: ±0   44s :stopwatch: -1s   1 suites ±0     7 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 29a5564a. ± Comparison against base commit a02058e2.

:recycle: This comment has been updated with latest results.

codecov[bot] commented 5 months ago

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (a02058e) 27.01% compared to head (29a5564) 26.78%.

Files Patch % Lines
src/journeys_utils.js 0.00% 18 Missing :warning:
src/branch_view.js 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #982 +/- ## ========================================== - Coverage 27.01% 26.78% -0.23% ========================================== Files 15 15 Lines 2347 2367 +20 ========================================== Hits 634 634 - Misses 1713 1733 +20 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.