Update gate-keep.yml to run on master

[cameroncooks-branch]

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• [ ] Unit test
• [ ] Integration test

JS Budget Check

Please mention the size in kb before abd after this PR

Files	Before	After
dist/build.js.
dist/build.min.js

Checklist:

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been merged and published in downstream modules
• [ ] I have checked my code and corrected any misspellings

Mentions:

List the person or team responsible for reviewing proposed changes.

cc @BranchMetrics/saas-sdk-devs for visibility.

[github-actions[bot]]

Test Results

127 tests   120 :white_check_mark:  51s :stopwatch:   1 suites    7 :zzz:   1 files      0 :x:

Results for commit ca07a4fa.

[JagadeeshKaricherla-branch]

Wouldn’t this fail to run when a PR is actually created ? I think we should continue to have pull_request trigger along with the newly added push trigger

[cameroncooks-branch]

Why would this fail when a PR is created? Push should run on all commits on any branch, including branches with open PR's

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1f3ab2a) 27.01% compared to head (ca07a4f) 27.01%. Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #988 +/- ## ======================================= Coverage 27.01% 27.01% ======================================= Files 15 15 Lines 2347 2347 ======================================= Hits 634 634 Misses 1713 1713 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[JagadeeshKaricherla-branch]

AFAIK, push will not run when a new pull request is opened or re-opened. Example : you have a development branch for which team members were pushing commits (GHA gets run because of push trigger) and after a while , when you decide to open a new PR to merge this development branch to master, the GHA wouldn’t run as it is not a push Other scenario could be opening a PR for a fork branch. so my proposal is to have both the triggers.

[cameroncooks-branch]

If you open or reopen a PR for a branch, the latest commit on the PR should have already had the workflow ran on it.

Reopening a PR or opening a new PR on old code would most likely require you to merge master into your branch (assuming that 'must be up to date with master before merging' option is set), in which case a new run would be triggered anyways

opening/closing/reopening a PR is decoupled from any actual code changes, unless i am misunderstanding how this works, the push option should cover these use cases already