BranchMetrics / xamarin-branch-deep-linking-attribution

The Branch Xamarin SDK for deep linking and attribution. Branch helps mobile apps grow with deep links / deeplinks that power paid acquisition and re-engagement campaigns, referral programs, content sharing, deep linked emails, smart banners, custom user onboarding, and more.
https://docs.branch.io/apps/xamarin/
MIT License
72 stars 17 forks source link

There are no examples for Xamarin Forms and documentation is OUT OF DATE. #130

Open Nerves82 opened 4 years ago

Nerves82 commented 4 years ago

Xamarin Forms documentation needs to be improved!! It is woefully out of date and inaccurate.

The documentation provides a link for a xamarin forms implementation but when clicking it one is taken to a xamarin native implementation.

https://github.com/BranchMetrics/xamarin-branch-deep-linking-attribution/tree/master/Branch-Xamarin-Testbed.iOS

https://github.com/BranchMetrics/xamarin-branch-deep-linking-attribution/tree/master/Examples/ios_example

Neither of theses are Xamarin Forms apps.

In the documentation for using Xamarin Forms we are told to have 2 classes that both inherit from "Application", one that implements IBranchSessionInterface and one that implements IBranchBUOSessionInterface. I have found that it is the iOS AppDelegate that has to implement IBranchSessionInterface and NOT the Forms "Application" class since the call to Init the service requires an instance of the IBranchSessionInterface passes as "this".

BranchIOS.Init("key_live_XxxXXXXX", options, this); <-- "this" is IBranchSessionInterface

The docs say "Change the C# project's profile to PCL 4.5 - Profile78". Xamarin Forms is beyond PLCs now that it is .NET standard compatible.

Can you fix the Xamarin Forms documentation to be correct and up to date? Can we get a up to date Xamarin Forms sample project?

ScarletKuro commented 3 years ago

Totally agree, the documentation is absolutely disgusting. Not even saying that it has code mistakes Img

echo-branch commented 3 years ago

Really sorry about the docs situation. We've lost our regularly Xamarin maintainer and have not backfilled the position yet.