search

Branchout / branchout

A manyrepo management tool to allow for local monorepo projecting while keeping everything in distinct repositories
Apache License 2.0
9 stars 2 forks source link

Branchout mvn -f pom.xml prevents pom-less mvn operations that need settings.xml from being conveniently run #84

Open fredcooke opened 3 years ago

fredcooke commented 3 years ago

For example, mvn deploy:deploy-file does not require a pom.xml locally but does need settings depending upon to where you're trying to deploy.

Given that pom.xml is the default project object model and is used in the 5 9s cases in almost every maven project ever, why can we not rely on the default to use pom.xml instead of calling it explicitly when there are use cases that don't make sense to require it for that then force you to either manually run the command outside branchout (defeating the purpose) or create a fake pom with just parent and basics just to satisfy the requirement and let it run okay.

I never understood this, however it didn't cause me any trouble until recently, so I never complained about it (mentioned it a year or so back, but that's it).

Are there any valid reasons why we can't simply stop doing that?

stickycode commented 3 years ago

Assuming you have a branchout projection and are using maven you probably have a project that has a pom. But i guess there is no need to explicitly set it.

Try change it and see if the tests pass.

On Mon, 30 Aug 2021, 12:33 Fred Cooke, @.***> wrote:

Assigned #84 https://github.com/Branchout/branchout/issues/84 to @stickycode https://github.com/stickycode.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Branchout/branchout/issues/84#event-5223343878, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG4GFDFDRJFKXLGSU42O5TT7LGVNANCNFSM5DAZJTSQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

fredcooke commented 3 years ago

Okay, I see why it was added and also how to remove it without breaking that. I'll have a crack at some point. Cheers.

fredcooke commented 3 years ago

Sees like you never got the #82 build fixed though?