Branchout / branchout

A manyrepo management tool to allow for local monorepo projecting while keeping everything in distinct repositories
Apache License 2.0
9 stars 2 forks source link

Make a few sorts unique so that even bad data produces good usable output #90

Closed fredcooke closed 1 year ago

fredcooke commented 2 years ago

Fixes #89

Enhancement to this could be to warn user that it's bad if input list size not equal output list size or fix it if it's bad straight up seeing as we modify it without explicit permission anyway.

fredcooke commented 2 years ago

Build failure is from shellcheck on osx because brew gives you the latest and is complaining about line 69 of branchout-groups (pre-existing code) with this link:

https://github.com/koalaman/shellcheck/wiki/SC2295

However it doesn't really cover the exact case and it seems to be either a false positive or my syntax highlighting is broken or it's not possible to do what you are doing AND satisfy shellcheck or something. Full text:

# output: 
# In branchout-group line 69:
#     noPrefix="${1#${BRANCHOUT_PREFIX}-}"
#                   ^-----------------^ SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
# 
# Did you mean: 
#     noPrefix="${1#"${BRANCHOUT_PREFIX}"-}"
# 
# For more information:
#   https://www.shellcheck.net/wiki/SC2295 -- Expansions inside ${..} need to b...
fredcooke commented 2 years ago

@stickycode there's now two failures on mac - both new shellcheck checks - Linux passing. Please merge if you're happy. Note I'm not happy but I think it's a step in the right direction, just more required to be good on the status front.

fredcooke commented 1 year ago

@stickycode I can't override the status requirement so feel free to merge on my behalf and generate a new release of it if you want.

fredcooke commented 1 year ago

It wasn't an override in the end, on refresh, not sure what changed.