search

BrandMeister / bm-rpt2aprs

Uploads repeaters of a BrandMeister network to APRS
MIT License
3 stars 4 forks source link

parse-ssid #11

Open pjao opened 6 years ago

pjao commented 6 years ago

This last PR could created a issue.

If the repeater as already an ssid, and the user id matches the rule, it will be added another ssid

Of course the function make_callsign_valid fix it, but I think that it should be validated before.

Example:

getting info for repeater id 643000199... parse ssid from repeater id sending location to aprs for C91PM-6-99 aprs text: openSPOT 435.0000/435.0000 CC1 aprs data: C91PM-6>APBM1S,TCPIP*:@112210z2558.74S/03237.20EQPHG0500openSPOT 435.0000/435.0000 CC1

As @cyanide-burnout as told before, we must keep with the rules.

Callsigns for AX.25 must: Consist of only upper case letters and numbers Have a base callsign before the SSID at least three characters long Have a numeric SSID which falls in 0 - 15 Have a base callsign before the SSID no longer than six characters In this context alphanumeric is defined as any ASCII values in the range: decimal [65 - 90] - 'A'-'Z' decimal [48 - 57] - '0'-'9'

nonoo commented 6 years ago

Can you please submit a pull request to fix the issue?