BrandOriented / PimcoreCiHubConnector

This bundle adds full integration between Pimcore and CI-HUB Connector. Now you can add, delete and download all assets, lock and unlock, get all versions for specified asset and much more.
https://brandoriented.io/
Other
5 stars 6 forks source link

Auto-registration NelmioApiDocBundle during enable bundle #11

Closed vmalyk closed 8 months ago

vmalyk commented 8 months ago

As I see you have configration for NelmioApiDocBundle, but for run it properly, I need enable NelmioApiDocBundle and manage by bundle order. As I see Pimcore has way how to manage that and implementation DependentBundleInterface will fix and no need extra steps for setup. Doc: https://pimcore.com/docs/platform/Pimcore/Extending_Pimcore/Bundle_Developers_Guide/Bundle_Collection#bundle-dependencies Example: https://github.com/pimcore/advanced-object-search/blob/5.x/src/AdvancedObjectSearchBundle.php#L103-L108

Please review,