search

BrandOriented / PimcoreCiHubConnector

This bundle adds full integration between Pimcore and CI-HUB Connector. Now you can add, delete and download all assets, lock and unlock, get all versions for specified asset and much more.
https://brandoriented.io/
Other
5 stars 6 forks source link

No method available: `getCommonProperties` #54

Closed NiklasBr closed 5 months ago

NiklasBr commented 6 months ago

https://github.com/BrandOriented/PimcoreCiHubConnector/blob/d1be407acfbe035ba161f5d1d6d3c20a84df47cc/src/Elasticsearch/Mapping/DataObjectMapping.php#L23

Can't find getCommonProperties() anywhere in the code base unfortunately. Is it supposed to be something else?

github-actions[bot] commented 6 months ago

Thank you for reporting this problem!

This is an open source project, and we rely on the community to help us diagnose and fix issues, as it is not possible to investigate and fix every issue reported to us via GitHub.

If possible, please create a pull request that fixes the problem you describe, along with appropriate tests. All pull requests will be promptly reviewed by the BrandOriented team.

Thank you very much!

betterapp commented 6 months ago

@NiklasBr it is defined in parent class here

vendor/bo-hub/ci-hub-api-bundle/src/Elasticsearch/Mapping/DefaultMapping.php

NiklasBr commented 6 months ago

@betterapp please show me which line getCommonProperties() is!

image

When I look at https://github.com/BrandOriented/PimcoreCiHubConnector/blob/master/src/Elasticsearch/Mapping/DefaultMapping.php

I only see these methods:

Screenshot 2024-05-23 at 14 54 38

betterapp commented 6 months ago

Hmmm

You are right: In 3.0.16 it exists.

betterapp commented 6 months ago

@labudzinski

As I see it was removed in 3.0.17 https://github.com/BrandOriented/PimcoreCiHubConnector/commit/0a2cc97498fe703e739136a35b9034e8f17697b5#diff-ea69977ad2ffff202639a4b7de42c8b612dddf30d8b3857a1e53210b12fb5684L43

But call the method is not removed (or maybe the method should not be removed ?) I do not know the context of the PR

NiklasBr commented 6 months ago

What should we do @betterapp?

betterapp commented 6 months ago

@NiklasBr

I do not know if call of this method should be just removed ? That mean the ES schema was changed ? I do not know the context of the PR.

@labudzinski

labudzinski commented 5 months ago

The method used to create the ES index has been changed to be more explicit. Fixed deficiencies in code.