Open NiklasBr opened 4 months ago
Thank you for reporting this problem!
This is an open source project, and we rely on the community to help us diagnose and fix issues, as it is not possible to investigate and fix every issue reported to us via GitHub.
If possible, please create a pull request that fixes the problem you describe, along with appropriate tests. All pull requests will be promptly reviewed by the BrandOriented team.
Thank you very much!
The method used to create the ES index has been changed to be more explicit. Fixed deficiencies in code.
Seems fixed now.
Sorry but it is still an issue.
Example:
Installation has about 30 000 assets and 14 000 products (variants and objects). Yet it still indexes over 90 000 elements (which appears to match all dataobjects and all assets in total).
@labudzinski I think I see the issue here:
These lines re-indexes all objects in the objects
table and does not take into consideration that sometimes a specific set of classes only should be indexed.
In the IndexPersistenceService class in the update method: https://github.com/BrandOriented/PimcoreCiHubConnector/blob/d00a8e8a3fa0b87658e0c29ebf839aefe0e6f702/src/Elasticsearch/Index/IndexPersistenceService.php#L321 https://github.com/BrandOriented/PimcoreCiHubConnector/blob/d00a8e8a3fa0b87658e0c29ebf839aefe0e6f702/src/Elasticsearch/Index/IndexPersistenceService.php#L322 We check whether the class is declared in the configuration.
The lines I show above cause a massive unnecessary congestion in the messenger queue by queuing elements which should not be indexed. We can improve performance and reduce strain on the logging system a lot by not doing that in the first place.
Pimcore version(s) affected
11.2.3
Description
When running the command
bin/console datahub:index:rebuild mycomfigname
I expect it to re-index DataObjets only in the given config.Instead it also indexes unrelated DataObjects.
How to reproduce
Example config name:
Then run
bin/console datahub:index:rebuild ci_hub_1
Possible Solution
No response
Additional Context
No response