search

BrandenEK / Blasphemous.LostDreams

Miscellaneous performance improvements
MIT License
4 stars 5 forks source link

adds `EventHandler`s for parrying #65

Closed EltonZhang777 closed 3 weeks ago

EltonZhang777 commented 3 weeks ago

OnParryFail triggers both when whiffing a parry and when attempting to parry a non-parriable attack. The 3 other handlers are self-explanatory.

EltonZhang777 commented 3 weeks ago

There's actually a bead that Schiff proposed, Feather from a Simurgh, that benefits from parrying (that's actually my revision to it that Schiff approved of, we can make it simpler anyway). And also I suppose there's gotta be some items that are related to parrying, so if this is not super necessary for the time being, it's good to not put extraneous code in LD project. (I'll use my Screaming Sinners mod to experiment with all the crazy functionalities)

Also, thanks for the good coding practices reminder! I'll definitely follow them in my code.

BrandenEK commented 3 weeks ago

Ah I see. Sounds good, once we require the parrying event we can either reopen this pr or make a new one