Brandon-mcn / ghgtools

https://brandon-mcn.github.io/ghgtools/
Other
1 stars 3 forks source link

Comments on GHG tools #3

Open maxwell-miller-geo opened 2 months ago

maxwell-miller-geo commented 2 months ago

function "create_templates" could specify a folder location to save the templates. If there is no specified location, it can default to a temporary directory. There are some comments and suggestions within the function that might work. Good documentation and examples on inputs for the function ghg_inventory().

Within the knitted "ghgtools.Rmd" I think you could show you called the "Activity Data" and the "Asset Portfolio" data sets because it isn't showing the code block right now.

I added some comments to the ghg_inventory and create_templates functions for more details.

Overall, everything works really well. The documentation is good.

Some things to consider or add, 1) Creating a helper function to check that input columns exist for Activity Data and Asset Portfolio. 2) Creating a helper function that can use partial matches on strings for items within a table, if things are close enough to match - might be a little time consuming, but it could make it a little more error resistant. See "regular expressions in R" https://cran.r-project.org/web/packages/stringr/vignettes/regular-expressions.html 3) Saving the outputs to a specified location; that way, people can work on the datasheets in Excel/wherever and know where they are located.

I hope this helps!