search

BrandonArmand / Binari

Interactive code editor with a live binary tree visual designed to teach new developers the fundamentals of Data Structures.
https://binari.dev
MIT License
181 stars 113 forks source link

Fix bug when running code through hotkey #49

Open BrandonArmand opened 4 years ago

BrandonArmand commented 4 years ago

What needs to be done.

When the user presses (ctr+enter), the code runs; however, it will also enter a new line, that needs to be fixed.

SPECS: Mac - Safari, and Firefox.

Why

The hotkey doesn't pause input.

How

One solution that might work could be by pausing text input when control is being held.

OmarShezan commented 4 years ago

I can't recreate this issue but let's see if anyone else has this problem.

ram170 commented 4 years ago

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

BrandonArmand commented 4 years ago

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

@ram170 Sure thing. It seems to be a bug for macs. Goodluck!

ram170 commented 4 years ago

Hi @BrandonArmand ! Can I take this? The change for this is very minimal, so I'd like to take one more issue if that's not a problem.

@ram170 Sure thing. It seems to be a bug for macs. Goodluck!

Yup. Checked it. Thank you!

ram170 commented 4 years ago

@BrandonArmand Can you review and merge this PR #61 ?

chintanpuggalok commented 1 year ago

is it still open?