BrandonKirbyson / VSCode-Animations

A VSCode extension that adds animations to the editor
https://marketplace.visualstudio.com/items?itemName=BrandonKirbyson.vscode-animations
MIT License
213 stars 6 forks source link

Side pane slide animation not working with images or jupyter notebooks #34

Closed EgeCaliskan closed 7 months ago

EgeCaliskan commented 1 year ago

Everything works normally and the animations play out as they are supposed to, but whenever I open up a jupyter notebook or an image the side panel sliding doesn't work. It just dissapears when I hit ctrl + b instead of sliding to the side. I also noticed that smooth scrolling option in VS Code's own settings doesn't work with notebooks, but I'm not sure if this is related to the problem.

BrandonKirbyson commented 1 year ago

Ok, I might look into this soon but currently animations partially disable when an iframe (jupyter notebook uses iframes and image likely too) is detected because vscode manually calculates iframe sizing so it does not animate properly and previously when I tried it ended up breaking iframes entirely (making them odd widths).

MrT-tak commented 7 months ago

Hi I just reinstalled vscode and got vscode animations working. I don't know if it because I have soo many items in one folder but the slide animations is not working. Is there any possible reasons for this? Thanks!

nvm it worked after a restart