BrandonKirbyson / VSCode-Animations

A VSCode extension that adds animations to the editor
https://marketplace.visualstudio.com/items?itemName=BrandonKirbyson.vscode-animations
MIT License
213 stars 6 forks source link

Editor laggy when scrolling in smooth mode #74

Closed renodesper closed 1 month ago

renodesper commented 2 months ago

I've noticed a significant performance drop when scrolling within the editor while "smooth mode" is enabled. The editor becomes noticeably laggy, making it difficult to work efficiently.

I believe this issue is caused by the smooth scrolling effect being applied to the editor, which is not optimized for this type of animation.

Would it be possible to exclude the editor from the smooth mode effect? This would allow for a smoother scrolling experience within the editor while maintaining the overall smooth mode experience in other parts of the application.

Arteiimis commented 1 month ago

same here

NgeNXQ commented 1 month ago

The same issue. Terminal and explorer views are laggy as well

BrandonKirbyson commented 1 month ago

Ok sorry, I'll look into it later. Slight performance issues are expected but sounds like something weird is happening now.

BrandonKirbyson commented 1 month ago

Sorry for the delay, should now be fixed in the new version, 2.0.4. Please let me know if it works or if there are any new issues because I redid the way smooth mode works to make it more efficient.

NgeNXQ commented 1 month ago

It might have become better but the stuttering is still there :( Is it possible to achieve the behavior where the smooth-mode does not affect scrolling in the editors and views at all (but preserving the cool animations of hiding/showing editors and sidebars)? Also, it is kinda counter-intuitive because there are separate preferences in vsc to accomplish these tasks e.g. "editor.smoothScrolling", workbench.list.smoothScrolling" and so on

BrandonKirbyson commented 1 month ago

Ok thanks for the feedback, it shouldn't be affecting or applying anything to the editor but maybe I'll add a setting to use a simple version of smooth mode.

NgeNXQ commented 1 month ago

It would be really nice. Thanks for your time and effort!

BrandonKirbyson commented 1 month ago

Could you double check that you updated it please, for me it is perfectly smooth. If it still persists please try Animations: Install Animations. If it still is an issue I can try fixing it, just want to check first. Thanks.

NgeNXQ commented 1 month ago

Thank you so much! Animations: Install Animations did its thing. Thanks for such an awesome extension!

BrandonKirbyson commented 1 month ago

Ok great, thanks!