Added interfaces to allow for mocks in unit testing

BrandonPotter / SimpleTCP

Straightforward .NET library to handle the repetitive tasks of spinning up and working with TCP sockets (client and server).

Apache License 2.0

365 stars 108 forks source link

Added interfaces to allow for mocks in unit testing #11

Open Scott-Lyons opened 7 years ago

Scott-Lyons commented 7 years ago

Fixes #10

BrandonPotter commented 7 years ago

Haven't reviewed yet - you guys know if this breaks any existing usage (is this a major or minor rev)?

yarimiz commented 6 years ago

Any idea when this PR is going to be merged and released?

Scott-Lyons commented 6 years ago

I raised this PR a while ago due to not being able to mock the SimpleTcpClient (and thus making testing more difficult). At the time I worked around this issue (rather than waiting for the merge).

As of right now I am no longer using the SimpleTcpClient and given the time taken to get this PR merged, I'm assuming it's not that much use to anyone else, so could probably be closed?