search

BrandonSmithJ / MDN

Mixture Density Network for water constituent estimation
GNU General Public License v3.0
40 stars 34 forks source link

setup.py file? #5

Closed bziniti closed 3 years ago

bziniti commented 3 years ago

Thank you for making this code available! Your paper about chla retrievals was very interesting and I'm looking forward to understanding the model more.

Was wondering if you have considered adding a setup.py file for easy use? (related to #2 )

It would make pip install git+https://github.com/BrandonSmithJ/MDN possible.

I used this workaround https://stackoverflow.com/questions/9714635/how-to-install-python-module-without-setup-py/9714750#9714750 but perhaps helpful for future use.

BrandonSmithJ commented 3 years ago

You're welcome!

Yes that is one potential option in addition to pypi. Unfortunately, getting the module available there has taken a backseat while I've been working to get things upgraded to TF2.x, which requires some major rewrites. Once that's ready, it will be released on PyPi at the same time to allow easy pip installs.

In the meantime though, I'll look into just adding a quick setup file. Thanks for the suggestion!

BrandonSmithJ commented 3 years ago

I've now added support for pip install git+https://github.com/BrandonSmithJ/MDN - let me know if you run into any issues!

bziniti commented 3 years ago

@BrandonSmithJ Thank you so much! This is great!