Closed raress96 closed 9 years ago
Some answers:
Thanks for the answers.I will update this issue with other questions that I don't know the answers to.
For the other stuff 1. I wanted to know what metadata is which ingot, but I forgot to look at the icon names :) That's what happens when you do 2 hours of cleanup :P
Lol.
Tools aren't registering in the creative inventory. Wierd.
Could you please commit EVERYTHING you have worked on? I want to make a huge cleanup and go through all the classes (again...) and clean them up with the proper formatting and also delete old ones and maybe make some optimizations. I need to do this alone and only if you don't work on anything new so it's easier to manage the files...
Gimme a minute, I'm just re-implementing Cast Iron Lamps.
Also, could you leave stuff related to Vanity System, Lightning Gun and Armor Editor, those are WIP ;)
Other questions: 1: What is the TeslaCoil?There is a rouge TeslaCoil model. 2: Is the Drop Hammer Still going to be implemented?There is a rouge model standing around.
Pro tip: Select a filed in eclipse and press CTRL + SHIFT + G to see all the classes where it is used.This helped me very much with the cleanup,
Hmm, the Tesla Coil doesn't have a model yet, so I should probably bind that old one for now, so keep that.
Drop hammer will eventually be implemented, but delete that model.
Also, SteamcraftConfigGUI shouldn't be registered anywhere?
Do you mean isn't?
If you select the class name and hit CTRL + SHIFT + G it will tell you where it is used.It seems to not be used anywhere...
Ah, so you did mean isn't. Ok, I shall look into that. That's meant to hook into Forge's new In-Game Config, but that doesn't work without a mcmod.info, which I don't know where to put in my workspace setup, so I can't test it.
Well the cleanup is done. I will also clean BoilerPlate maybe tomorrow cause that is very cluttered as well.
Also be sure to use the latest formatter and also set up the code templates properly and change the author under comments to your name cause I noticed that your author tag doesn't get added automatically(or at least some classes din't have it.
Ok :D
Gonna close this to clean the issue tracker a bit
Important stuff: 1.The SplashesHelper is not registered anywhere. 2.EventHandlerDrawHighlight does what exactly? 3.What does the ItemMonocle do? 4.Is ItemGuideBook obsolete? 5.What does the ItemLightningGun do? 6.Is ItemParts class still used? 7.What is the ItemPipe class? 8.What is the ItemSpanner? 9.Do we still implement the ItemTeaSeed? 10.What is EntitySmallLightningBolt used for? 11.What is EntityPlayerExtended?
If any of the answers to the above question is "idk", please delete the class and all references.Thank you :)
Other stuff: 1.Can you please add a comment with the ingot names and metadata to ItemIngot class?