BrassGoggledCoders / Steamcraft2

SC2 is a mod that adds Steampunk-themed power generation, blocks, items, and so much more.
http://www.minecraftforum.net/topic/2789096-172-steamcraft2-30614-beta1-the-beginning/
Creative Commons Attribution Share Alike 4.0 International
14 stars 13 forks source link

The Miscellaneous Issues/Questions Page #133

Closed raress96 closed 9 years ago

raress96 commented 10 years ago

Important stuff: 1.The SplashesHelper is not registered anywhere. 2.EventHandlerDrawHighlight does what exactly? 3.What does the ItemMonocle do? 4.Is ItemGuideBook obsolete? 5.What does the ItemLightningGun do? 6.Is ItemParts class still used? 7.What is the ItemPipe class? 8.What is the ItemSpanner? 9.Do we still implement the ItemTeaSeed? 10.What is EntitySmallLightningBolt used for? 11.What is EntityPlayerExtended?

If any of the answers to the above question is "idk", please delete the class and all references.Thank you :)

Other stuff: 1.Can you please add a comment with the ingot names and metadata to ItemIngot class?

FreneticScribbler commented 10 years ago

Some answers:

  1. Nothing at the minute, awaiting merge into correct other handlers.
  2. '' Basically monocle is planned to be for information purposes, showing block name, hardness, resistance etc when mousing over block, compared to the goggles, which will be gameplay based.
  3. Yes.
  4. Working on it! It will have two different modes, sphere and beam, one a projectile and one a continuous beam, and will use power from electric jars. Basically electric gun...
  5. Uh, ItemParts is still used, yes. (I think)
  6. Something from an experiment I was doing. Can be deleted for now.
  7. Simply rotates blocks atm. Probably going to do something machine related at some point.
  8. I'll reimplement tea! Seems like something nice and easy to help break my minor burnout.
  9. Projectile for Lightning gun ;)
  10. Part of the vanity inventory, which I will also reimplement after modular armor Other:
  11. What do you mean? You can use the icon names for reference.
raress96 commented 10 years ago

Thanks for the answers.I will update this issue with other questions that I don't know the answers to.

For the other stuff 1. I wanted to know what metadata is which ingot, but I forgot to look at the icon names :) That's what happens when you do 2 hours of cleanup :P

FreneticScribbler commented 10 years ago

Lol.

FreneticScribbler commented 10 years ago

Tools aren't registering in the creative inventory. Wierd.

raress96 commented 10 years ago

Could you please commit EVERYTHING you have worked on? I want to make a huge cleanup and go through all the classes (again...) and clean them up with the proper formatting and also delete old ones and maybe make some optimizations. I need to do this alone and only if you don't work on anything new so it's easier to manage the files...

FreneticScribbler commented 10 years ago

Gimme a minute, I'm just re-implementing Cast Iron Lamps.

Also, could you leave stuff related to Vanity System, Lightning Gun and Armor Editor, those are WIP ;)

raress96 commented 10 years ago

Other questions: 1: What is the TeslaCoil?There is a rouge TeslaCoil model. 2: Is the Drop Hammer Still going to be implemented?There is a rouge model standing around.

Pro tip: Select a filed in eclipse and press CTRL + SHIFT + G to see all the classes where it is used.This helped me very much with the cleanup,

FreneticScribbler commented 10 years ago

Hmm, the Tesla Coil doesn't have a model yet, so I should probably bind that old one for now, so keep that.

Drop hammer will eventually be implemented, but delete that model.

raress96 commented 10 years ago

Also, SteamcraftConfigGUI shouldn't be registered anywhere?

FreneticScribbler commented 10 years ago

Do you mean isn't?

raress96 commented 10 years ago

If you select the class name and hit CTRL + SHIFT + G it will tell you where it is used.It seems to not be used anywhere...

FreneticScribbler commented 10 years ago

Ah, so you did mean isn't. Ok, I shall look into that. That's meant to hook into Forge's new In-Game Config, but that doesn't work without a mcmod.info, which I don't know where to put in my workspace setup, so I can't test it.

raress96 commented 10 years ago

Well the cleanup is done. I will also clean BoilerPlate maybe tomorrow cause that is very cluttered as well.

Also be sure to use the latest formatter and also set up the code templates properly and change the author under comments to your name cause I noticed that your author tag doesn't get added automatically(or at least some classes din't have it.

FreneticScribbler commented 10 years ago

Ok :D

FreneticScribbler commented 9 years ago

Gonna close this to clean the issue tracker a bit