Obsidian Armor fire immunity doesn't work - Githubissues

BrassGoggledCoders / Steamcraft2

SC2 is a mod that adds Steampunk-themed power generation, blocks, items, and so much more.

http://www.minecraftforum.net/topic/2789096-172-steamcraft2-30614-beta1-the-beginning/

Creative Commons Attribution Share Alike 4.0 International

14 stars 13 forks source link

Obsidian Armor fire immunity doesn't work #239

Closed WolfieWaffle closed 9 years ago

WolfieWaffle commented 9 years ago

I mentioned a while ago that obsidian armor should probably not use potion effects. I saw somewhere that it was changed, but there are still some issues:

Obsidian armor still gives you slowness potion effect, rather than using playerAttributes to make it heavy.
The fire resistance does not work.

I am using the jenkins build 16.

FreneticScribbler commented 9 years ago

I've not yet switched the slowness, only the fire resistance...I'll investigate it being broken.

raress96 commented 9 years ago

Fire immunity can't be easily coded because you can change the player resistance to fire, but you have to change it back when the armor is not worn anymore, which is just more complicated than just using a potion effect.

FreneticScribbler commented 9 years ago

You can just extinguish them if they are on fire, no?

FreneticScribbler commented 9 years ago

Dirty, but it works.

FreneticScribbler commented 9 years ago

Or should :P

raress96 commented 9 years ago

Yes, but they get extinguished only when they come out of the fire, but they still get damaged while they are in fire.

FreneticScribbler commented 9 years ago

Hrm. Ok.

WolfieWaffle commented 9 years ago

Wait, so is this still open or did someone fix it? The first part seems like it got fixed, but the conversation afterwards seems like it's not.

On Thu, Jul 9, 2015 at 5:08 AM, Arona Jones notifications@github.com wrote:

Hrm. Ok.

— Reply to this email directly or view it on GitHub https://github.com/BrassGoggledCoders/SteamCraft2/issues/239#issuecomment-119912852 .

FreneticScribbler commented 9 years ago

Its all working, back to using a potion effect for fire resistance tho

WolfieWaffle commented 9 years ago

Ok, that's fine. As long as it doesn't override existing fire resistance effects you have on. Also, are the particles ambient?

FreneticScribbler commented 9 years ago

Should be

FreneticScribbler commented 9 years ago

Oooh, it might override existing fire resist though. Not much I can really do about that...

WolfieWaffle commented 9 years ago

Maybe you could only apply it if you don't already have fire resistance?

On Tue, Jul 14, 2015 at 2:50 PM, Arona Jones notifications@github.com wrote:

Oooh, it might override existing fire resist though. Not much I can really do about that...

— Reply to this email directly or view it on GitHub https://github.com/BrassGoggledCoders/SteamCraft2/issues/239#issuecomment-121381299 .

ghost commented 9 years ago

I'm pretty sure it doesn't affect existing fire resistance. If the current effect is longer, than it doesn't change.