search

Bratanov / community-driven-radio

A radio station driven by the community
10 stars 1 forks source link

Feature/Song notification #21

Closed Yavor-Ivanov closed 7 years ago

Yavor-Ivanov commented 7 years ago

I added a desktop notification when the song changes. This is what it looks like:

screen shot 2016-11-21 at 4 11 56 pm

I use the video thumbnail address from issue #20.

Yavor-Ivanov commented 7 years ago

I think something went wrong during the merge and it got reverted. I don't remember changing the order.

On 21 Nov 2016, at 17:17, Bratanov notifications@github.com wrote:

@Bratanov commented on this pull request.

In public/client.html:

@@ -36,6 +36,6 @@

+ The order of the imports here was intended. We had cases in which the callback defined here: https://github.com/Yavor-Ivanov/community-driven-radio/blob/4f0c6bfcd393d6a9cacfc68bde1868e2e0d02d6e/public/badass-client.js#L164 for the YouTube iframe API, was sometimes not called when https://www.youtube.com/iframe_api loads before our JS files.

Did you have any experiences with this, or it was moved for aesthetics?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.