search

Bratanov / community-driven-radio

A radio station driven by the community
10 stars 1 forks source link

Bug / Song not recognized #26

Closed Bratanov closed 7 years ago

Bratanov commented 7 years ago

Thanks to @xristo for reporting this bug.

Song with this URL: https://www.youtube.com/watch?v=T-w41FmxS7M Would not get added to the queue (with URL or ID), other songs work correctly.

There's currently no errors on our end, but it's probably because we're not throwing anything at the moment. 🐋

I did some quick digging, the YouTube response returned from this song seems a little different. Here's a diff of a working song (on the left) and this song (on the right) YouTube API response: https://www.diffchecker.com/xekRi7Va

First song is "embeddable": true and has a second request (for related) Second song is "embeddable": false, thus no second request.

We actually have this: https://github.com/Bratanov/community-driven-radio/blob/630fb5834d2581e39af6288b0e192bea476ff4d5/radio.js#L269-L271 but oh well..

We should throw errors. 🐳