BraveUX / braveux

Staging environment for our agency website.
http://braveux.github.io/braveux/
24 stars 6 forks source link

Stretch CMS Case Study: Visible masking blocks in image preview #308

Open theastralj opened 6 years ago

theastralj commented 6 years ago

In the image below, there are two off-background rectangles to the left and right of the timeline (if you can't see it on your own monitor, use a eyedropper tool to prove this):

image

ekfuhrmann commented 6 years ago

This is due to the image asset fade not using the same color as the background -- it's visible in the sketch file as well.

I've brought this up verbally to Sean, but this will be a better way to track that it gets fixed.

theseangoodwin commented 6 years ago

screen shot 2018-01-25 at 5 31 56 pm

This is how this file should actually look.

theseangoodwin commented 6 years ago

One of the images titled CMS-scrubber in here should work.

https://www.dropbox.com/sh/1o18e6imny9blr4/AACeWydWaWVXHZEye8mypBTka?dl=0

ekfuhrmann commented 6 years ago

@theseangoodwin I've added the 2x image you shared, but it's now missing the fade effect on each side of the scrobble.

image

theseangoodwin commented 6 years ago

@ekfuhrmann I've since updated the graphics to alpha mask that scrubber. This version should work now.