Brawl345 / Image-Reverse-Search-WebExtension

WebExtension: Adds an option to the context menu to search with an image on various services.
The Unlicense
120 stars 23 forks source link

Feature request: Allow us to name the Custom Search Provider and add multiple ones #10

Closed jingofett closed 7 years ago

jingofett commented 7 years ago

These functionalities will allow this add-on to be a complete replacement for Image Search Options

mknepper commented 7 years ago

I agree, adding the ability to name your Custom Search Engine and allow more than one Custom Search Engine would completely replace that other addon. Odds are this will be the most popular reverse image searching addon out of all of them.

Brawl345 commented 7 years ago

Yeah I will definitely look into this, naming shouldn't be hard but for multiple CSE I need to reorganize some more code.

EC-O-DE commented 7 years ago

There is only so few provider providing reverse image search / similar image search. Bing and Yahoo basically gave up. Tineye DB is small. Baidu?? Sure but it's censored beyond imagination.

Google and Yandex are truly best. Yandex is better at reverse-similar, Google is somewhat better finding same image but more sizes. Yandex finds different sizes as well but sometimes Google has few extra :)

mknepper commented 7 years ago

What does that have to do with the ability to add your own search engines? lol

krisu5 commented 7 years ago

@EC-O-DE You're focusing on general reverse image search engines, but there's many anime / illustration related reverse engines too, like SauceNAO and IQDB.

And most like there are other kinds of engines too, so it's doesn't make lot of sense for not giving more customizability.

MarshmallowCirno commented 7 years ago

I'd like to have option to add favicon for custom search engine too

MarshmallowCirno commented 7 years ago

@EC-O-DE Personally I search on encrypted.google.com to not being redirected on local google url (with .uk, .de, .fr etc) and search instead on english. Because search results are worse on local google version sometimes. So I added it as custom search engine

Brawl345 commented 7 years ago

Resolved in PR #15! Thanks @FlandreDaisuki!

EDIT: It's live on AMO!