search

Brawl345 / Image-Reverse-Search-WebExtension

WebExtension: Adds an option to the context menu to search with an image on various services.
The Unlicense
120 stars 23 forks source link

[bug][v3.4.3] "Save Options" button does not work #67

Closed AlttiRi closed 1 year ago

AlttiRi commented 1 year ago

On "Save Options" button click the error throws:

Uncaught TypeError: Cannot read property 'replace' of undefined
    at HTMLButtonElement.saveOptions.onclick (options.js:332)

So, it does not save the changes.

v3.4.1 works fine.

Brawl345 commented 1 year ago

sigh Sorry for this, will fix it ASAP.

Brawl345 commented 1 year ago

Fixed with v3.4.4, should be available soon on AMO.

AlttiRi commented 1 year ago

BTW, what exactly AMO wrote when it asked to update Bootstrap?

It seems meaningless for me to ask to update a CSS framework in an extension.

Brawl345 commented 1 year ago

That I'm only allowed to use stable versions. I used Bootstrap Alpha 4, that was like... 2017? I tried explaining it but the reviewer insisted that I use the stable version or else the add-on would be removed.

This add-on didn't pass review because of the following problems:

1) Your add-on includes a third-party library. Please provide the origin of the exact library version you were using and make sure you are using an exact copy of the original maintainer's release version. Established libraries must be included from their official source, in their original format without any modification (changing the file name does not matter). Please note that only stable releases are acceptable (not beta, pre, RC, dev etc) and that third party CDNs are not considered official sources. For more information, refer to https://extensionworkshop.com/documentation/publish/third-party-library-usage/.

  • options/css/bootstrap.min.css
Brawl345 commented 1 year ago

Update is now available on AMO.