Bug: Fix vote recast expanding voter array

BreadchainCoop / breadchain

2 stars 1 forks source link

Bug: Fix vote recast expanding voter array #7

Closed RonTuretzky closed 5 months ago

RonTuretzky commented 6 months ago

Great catch by @bagelface , voting multiple times with current implementation in 7a0e1ae will allow manipulation by casting multiple votes bloating the voters array

[ ] Create tests to cover this vulnerability
[x] Amend castVote function to account for vulnerability

bagelface commented 5 months ago

Will leave this open because we discussed a refactor of this logic, but the bug itself has been fixed.

RonTuretzky commented 5 months ago

Closing this, there will be major refactors to the voting logic.