Classic Era SoD Moonkin Aura spell crit calculation.

BreakBB / ExtendedCharacterStats

Extended Character Stats: A WoW Classic addon

MIT License

7 stars 18 forks source link

Classic Era SoD Moonkin Aura spell crit calculation. #308

Closed ElegantSerr closed 5 months ago

ElegantSerr commented 5 months ago

Bug description

ECS shows +3% and an additional +5% crit chance (a total of 8% spell crit bonus) after switching to Moonkin + Moonkin Aura. This does not update with buffs, removing Moonkin Aura removes the total 8%. Removing the aura sporadically lowers it by 5% instead, but the buff is removed (illustrated in screenshot) .

Screenshots

MoonkinSpellCrit

Version

ECS version 3.2.2, Classic Era Season of Discovery

ElegantSerr commented 5 months ago

Classic (Era SoD) automatically adds Moonkin Aura Bonus to all spell schools, causing double bonus calculation. Change line 41 in SpellCrit.lua -> if (spellId == 24907 and ECS.IsWotlk) then