search

BreakBB / ExtendedCharacterStats

Extended Character Stats: A WoW Classic addon
MIT License
7 stars 18 forks source link

In SOD spell hit is incorrect #325

Closed vidorgyozo closed 1 month ago

vidorgyozo commented 1 month ago

Bug description

In SOD it seems that the attack and spell hit chance is not counted for spell hit in ECS.

Screenshots

As you can see I have spell and attack hit items, and you can see they count for ranged hit (top) but not for spell hit (bottom). image

Version

Latest update for SOD right now, updated on 7/10/2024 from Curseforge.

retrobloodfang commented 1 month ago

Spell hit on Classic Era is also incorrect. My character shows 7% spell hit even though my mage talents and gear together should be 14% hit

BreakBB commented 1 month ago

I actually need to add the new SoD ring runes, which provide hit.

Other than that I am not aware of an actual issue.

But I do know about #173 which is kind of an issue, because "Spell Hit" is not detailed enough for talents which provide "Hit on Frost spells" or "Hit on Afflication spells".

@vidorgyozo can you provide an example item for "As you can see I have spell and attack hit items"? I don't understand what you mean by that 🤔