search

BreakOutEvent / breakout-backend

The backend for BreakOut
GNU Affero General Public License v3.0
12 stars 2 forks source link

Feature/perfect dev mock data #235

Open nerdsupremacist opened 5 years ago

nerdsupremacist commented 5 years ago

sounds good. Will do

tgraupne commented 5 years ago

This seems ok to me. Merge? @thepiwo @nerdsupremacist

thepiwo commented 5 years ago

I'd wait for adjustments regarding cleaning the data of specific persons

tgraupne commented 5 years ago

What exactly do you mean by that? I don’t understand where personal information come from in this scenario.

On 10. Apr 2019, at 21:37, Philipp Piwo notifications@github.com wrote:

I'd wait for adjustments regarding cleaning the data of specific persons

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BreakOutEvent/breakout-backend/pull/235#issuecomment-481832753, or mute the thread https://github.com/notifications/unsubscribe-auth/AHUOX0XS3KsCGz22fBvwpfnmWEs4hSapks5vfj1tgaJpZM4cUSQR.

thepiwo commented 5 years ago

The non-changed mock data creates specific users for Leo, Keno and David. I think it would be better to replace this with generic testing accounts and document the process on how his data can be used somewhere.