search

Breakend / experiment-impact-tracker

MIT License
273 stars 31 forks source link

On some platforms CPU freq results in error #8

Closed Breakend closed 4 years ago

Breakend commented 4 years ago

Traceback (most recent call last): File "<stdin>", line 1, in <module> File ".../python3.7/site-packages/psutil/__init__.py", line 1877, in cpu_freq ret = _psplatform.cpu_freq() File ".../python3.7/site-packages/psutil/_pslinux.py", line 703, in cpu_freq "can't find current frequency file") NotImplementedError: can't find current frequency file

To fix, I think we should add a compatibility check here: https://github.com/Breakend/experiment-impact-tracker/blob/master/experiment_impact_tracker/data_info_and_router.py#L168

and a try-catch here so that it just returns an empty list if it gets that exception: https://github.com/Breakend/experiment-impact-tracker/blob/cf486ebacae9b68ec4770de36fb537704105d6de/experiment_impact_tracker/cpu/common.py#L30-L33

Breakend commented 4 years ago

The try-catch is addressed in https://github.com/Breakend/experiment-impact-tracker/pull/9

Still need to do an initial compatibility check to prevent spammed log files

Breakend commented 4 years ago

Completely fixed by #29