implement a Field class similar to fields in Django, Marshmallow and DRF

BreakingBytes / simkit

Model Simulation Framework

http://breakingbytes.github.io/simkit/

BSD 3-Clause "New" or "Revised" License

27 stars 16 forks source link

implement a Field class similar to fields in Django, Marshmallow and DRF #68

Closed mikofski closed 7 years ago

mikofski commented 7 years ago

should resolve #9 Fields layer (altho not really a layer)
add Field base class to core
add test_field to test_core to see if a class constructor works
add new test_fields to carousel.tests to try to make a data class using fields

mikofski commented 7 years ago

@anomam this pr is ready for review, either put your comments here or look for the review button and click approve on the "Files Changed" tab or you can hunt for the review button - this help doc on reviews might help. thx and sorry it is so messy, it's a really heinous hack, not quite all of the v0.3 milestone stuff I wanted, but it had to be done.

anomam commented 7 years ago

I get an error when trying to run the pvpower model:

in sandia_perfmod_newstyle.py

----> 5 from carousel.core.data_sources import DataSource, DataParameter
      6 from carousel.core.formulas import Formula, FormulaParameter
      7 from carousel.core.calculations import Calc

ImportError: cannot import name DataParameter

anomam commented 7 years ago

Hey @mikofski, after spending a while on it I think I understand some of the big lines here, which is good. But a big portion of the commits is still quite abstract for me, so even if I can read the code and understand it line by line, I don't necessarily understand the context and the thought process. I do think though that I reached a point where I understand the global context enough to be able to talk about some of the implementations, and for this reason I'll switch to some of the model implementation.

Apart from the issue with the pvpower example, the PR looks ok to me.