Closed mikofski closed 8 years ago
Hey @mikofski , I reviewed all of the commits the best I could and it looks fine to me. I'm still figuring out a lot of what's going on in the framework so there's a chance I missed something, but I think it is good for merging right now! Are you going to update the documentation in a different PR?
Yes, I'll update the docs in a separate PR, I think that only fixes to issues in this PR should be added now. Thanks! Should I merge it then?
Yes!
This is a continuation of PR #77 and #68. It addresses several issues:
78 create model parameters to collect layer parameters and replace some constants like
layer_class_names
and make them more flexible76 simulation settings that switch or skip calculations, not possible without these changes
75 easily repeat (parameterize) calculations
63 split calculations
62 all layers should use Meta
59, #60 and #61 need a calculator class to implement uncertainty propagation to all calculations and simplify redundant code