Breakthrough-Energy / PostREISE

Analyze and plot post simulation data
https://breakthrough-energy.github.io/docs/
MIT License
6 stars 13 forks source link

Fix warnings raised by tests #375

Closed rouille closed 2 years ago

rouille commented 2 years ago

Pull Request doc

Purpose

Fix warnings. There are three kinds of warnings

Closes #374.

What the code is doing

Testing

Warnings are not raised

Where to look

Changes are mostly done in the test modules

Usage Example/Visuals

N/A

Time estimate

5min

jenhagg commented 2 years ago

We can also use a fixture to close the plot automatically after each test (I wasn't sure so tried it out in this branch)

BainanXia commented 2 years ago

We can also use a fixture to close the plot automatically after each test (I wasn't sure so tried it out in this branch)

That's smart.

rouille commented 2 years ago

We can also use a fixture to close the plot automatically after each test (I wasn't sure so tried it out in this branch)

That's smart.

Much cleaner. I will cherry pick your commit and update the PR

rouille commented 2 years ago

We can also use a fixture to close the plot automatically after each test (I wasn't sure so tried it out in this branch)

That's smart.

Much cleaner. I will cherry pick your commit and update the PR

Done