Breakthrough-Energy / PowerSimData

Simulation framework
https://breakthrough-energy.github.io/docs/
MIT License
52 stars 40 forks source link

Change constants of grid models #694

Closed rouille closed 2 years ago

rouille commented 2 years ago

Pull Request doc

Purpose

Update constants of grid models. To be able to reproduce the previous scenarios with the usa_tamu model, the default value for pmin_as_share_of_pmax is set to 1 (i.e. Pmin is equal to the power output given in the profile each hour) for hydro. As discussed in other channels, the value for ror is set to 0 (fully curtailable) in the europe_tub model. Finally, PHS is added to the list of clean resources.

What the code is doing

Change some constants value and update a dictionary

Testing

Current unit tests

Where to look

It is pretty minimal. The changes has been discussed during meetings and chat conversations.

Usage Example/Visuals

N/A

Time estimate

5min

lanesmith commented 2 years ago

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

BainanXia commented 2 years ago

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

rouille commented 2 years ago

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

Sounds good. Just to let you know, hydro and PHS will be combined to inflow. See comments here.

BainanXia commented 2 years ago

I forget what we discussed for TUB's hydro and PHS resources. They're currently listed as having pmin_as_share_of_pmax terms that are 0.9, but were they supposed to be fully flexible too (i.e., pmin_as_share_of_pmax values of 0)?

I think so, good catch.

Sounds good. Just to let you know, hydro and PHS will be combined to inflow. See comments here.

Ah, it clearer.