Fix storage conversion so pcm will be feasible

Breakthrough-Energy / PowerSimData

Simulation framework

https://breakthrough-energy.github.io/docs/

MIT License

52 stars 40 forks source link

Fix storage conversion so pcm will be feasible #726

Closed jenhagg closed 1 year ago

jenhagg commented 1 year ago

Purpose

Fix the infeasibility we encounter when adding storage.

What the code is doing

Set the values during pypsa_to_grid conversion in a way that is consistent with TransformGrid. This fixes the underlying issue of initial storage (presumably) violating the JuMP constraint.

Also applied latest black formatting.

Testing

Ran a 2 month pcm with the custom 128 node network, and got storage results files.

Time estimate

10 min

rouille commented 1 year ago

@FabianHofmann this PR fixes the infeasibility we encountered

FabianHofmann commented 1 year ago

Ah great!! Congrats, awesome debugging! Seemed to be quite difficult to find.