search

Breakthrough-Energy / SwitchWrapper

Wrapper for Switch
MIT License
1 stars 2 forks source link

fix: correct column co2_intensity entry in fuels.csv #59

Closed YifanLi86 closed 3 years ago

YifanLi86 commented 3 years ago

Pull Request doc

Purpose Debug grid_to_switch.py function to generate correct fuels.csv file for SWITCH input version 2.0.5.

What the code is doing Adjust original code to populate entries for column "co2_intensity" to "0" instead of ".".

Testing Manual testing, spot-checked against values.

from powersimdata.scenario.scenario import Scenario from switchwrapper.grid_to_switch import grid_to_switch scenario = Scenario(599) grid = scenario.state.get_grid() grid_to_switch(grid, 'Test')

Time estimate 5 minute.

rouille commented 3 years ago

Can you rebase your branch onto mvp. Also your commit message does not follow the standard (see the Contribution Guide), you will need to perform an interactive rebase to reword it. Thanks

YifanLi86 commented 3 years ago

Can you rebase your branch onto mvp. Also your commit message does not follow the standard (see the Contribution Guide), you will need to perform an interactive rebase to reword it. Thanks

Finished interactive rebase...

rouille commented 3 years ago

Is that the only place where "." needs to be changed to "0"? See l. 217, [l. 304 - l. 308]

YifanLi86 commented 3 years ago

Is that the only place where "." needs to be changed to "0"? See l. 217, [l. 304 - l. 308]

Yes 217 is the only location that needs to be changed as I observed. 304-308 are correct - no change needed.