search

Breakthrough / PySceneDetect

:movie_camera: Python and OpenCV-based scene cut/transition detection program & library.
https://www.scenedetect.com/
BSD 3-Clause "New" or "Revised" License
2.97k stars 374 forks source link

Extend image_name_template to allow timestamp #395

Closed Veldhoen closed 2 months ago

Veldhoen commented 2 months ago

Fixes #394

Breakthrough commented 2 months ago

I see in your PR you've already used the $TIMESTAMP_MS format as per the discussion in #394. Would you be able to run yapf to format the resulting code so it passes the formatting checks?

Thank you for the PR!

Veldhoen commented 2 months ago

Thanks for replying so fast, even though my PR was still a draft. I'll make sure to address the issues you mentioned, hopefully later today.

Veldhoen commented 2 months ago

Rebased on develop now, and I think the formatting is in line with your standards now. Also added $TIMECODE like you suggested in the issue, and added both $TIMECODE and $FRAME_NUMBER to test_save_images.

Documentation still needs to be updated to explain these extensions.

Veldhoen commented 2 months ago

I applied the requested changes, and extended docstring. Hope this will do!

Breakthrough commented 2 months ago

Much appreciated, approved.

Thank you for the PR!

Veldhoen commented 1 month ago

@Breakthrough When do you plan to release 0.6.4? I created a pre-release of my fork to be able to use the functionality right away, but I'd like to use a proper release at some point, of course.

Breakthrough commented 1 month ago

I'm hoping to wrap up the next release by the end of this month. If for whatever reason you need this sooner in production, I can consider pushing a pre-release to PyPI.

Veldhoen commented 1 month ago

If you can make it by the end of this month, that would be great. Until then we'll be fine with my ad hoc pre-release. Thanks!

Veldhoen commented 3 weeks ago

@Breakthrough do you have any updates concerning the release of 0.6.4? Would be much appreciated :)

Breakthrough commented 3 weeks ago

All feature work is complete, just finishing up testing and preparing the release. The new version should be out within a day or two.