search

BreankingBad / dashclock

Automatically exported from code.google.com/p/dashclock
Apache License 2.0
0 stars 0 forks source link

ability to set icon to a drawable #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
It would be nice, if you could set the used icon as Drawable or Bitmap. At the 
moment only a resource id is allowed, which limits the capabilities.

specific use case: my extension lets you launch apps right from the lockscreen, 
but atm only the extension's icon can be used (instead of the chosen app's) due 
to that limitation.

Original issue reported on code.google.com by C.Schart...@gmail.com on 13 Feb 2013 at 7:39

GoogleCodeExporter commented 9 years ago

Original comment by roman.nurik on 13 Feb 2013 at 7:42

GoogleCodeExporter commented 9 years ago 
Yeah, a bitmap or URI is doable. I just need to figure out how to make sure 
people don't pass in huge bitmaps.

Original comment by roman.nurik on 13 Feb 2013 at 7:43

GoogleCodeExporter commented 9 years ago 
Scaling the bitmaps when saving or throwing an error is ideal

Original comment by sukumar....@gmail.com on 16 Feb 2013 at 3:12

GoogleCodeExporter commented 9 years ago 
Note that if this feature gets implemented, the automatic monochrome filter 
will remain. That is, all icons will be white-on-transparent.

Original comment by roman.nurik on 17 Feb 2013 at 7:30

GoogleCodeExporter commented 9 years ago 
Imho that's perfectly fine, especially if you want to dynamically set icons 
(like i and the guy from "custom extension" want to do)! So the UI stays 
consistent. 
I am aware of the fact that this could cause issues with some icons, but I 
think it's worth the increased "consistency".

Original comment by C.Schart...@gmail.com on 17 Feb 2013 at 7:33

GoogleCodeExporter commented 9 years ago 
Issue 369 has been merged into this issue.

Original comment by roman.nurik on 13 Mar 2013 at 12:26

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 4210dd09a2b9.

Original comment by roman.nurik on 10 Jun 2013 at 7:03

GoogleCodeExporter commented 9 years ago 
Key sample code attached. paths.xml goes in res/xml/paths.xml. This will be 
available in v2 (hopefully shipping as part of DashClock 1.5).

Original comment by roman.nurik on 10 Jun 2013 at 7:05

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by roman.nurik on 12 Jun 2013 at 8:56

GoogleCodeExporter commented 9 years ago 
v1.5 has been published. Will take a few hours to propagate. Marking this 
feature/bug as closed.

Original comment by roman.nurik on 17 Jun 2013 at 8:26

GoogleCodeExporter commented 9 years ago 
With which versions (or all?) of DashClock will the new API (especially t his 
feature) work?

Original comment by C.Schart...@gmail.com on 17 Jun 2013 at 8:29

GoogleCodeExporter commented 9 years ago 
v1.5. I'll give an 'all clear' when it's at 90%+ of the install base. From my 
data it should take about a week.

Original comment by roman.nurik on 17 Jun 2013 at 8:48

GoogleCodeExporter commented 9 years ago 
I appreciate that. What would be nice though, would be some way to check the 
user's installed dashclock version. I am not yet aware of a way to do so, but 
might find some soon.

Original comment by C.Schart...@gmail.com on 17 Jun 2013 at 8:50

GoogleCodeExporter commented 9 years ago 
You can check the packageManager to get versions of apps, you may be able to 
use this to check the version. I do similar for a few apps. 

e.g.

int version = 
context.getPackageManager().getPackageInfo("app.package.name.you.want.to.Check",
 0).versionCode;

Original comment by andrewpm...@gmail.com on 17 Jun 2013 at 10:37

GoogleCodeExporter commented 9 years ago 
Do we need a new dashclock-api-rx.x.jar for this? It's still 1.1 on the 
downloads section of the project

Original comment by andrewpm...@gmail.com on 17 Jun 2013 at 10:40

GoogleCodeExporter commented 9 years ago 
@andrewpmoore, yes. I'll be releasing a new JAR and docs in the next few days. 
The source already has all the details.

Original comment by roman.nurik on 18 Jun 2013 at 12:07