BrechtDeMan / WebAudioEvaluationTool

A tool based on the HTML5 Web Audio API to perform perceptual audio evaluation tests locally or on remote machines over the web.
https://code.soundsoftware.ac.uk/projects/webaudioevaluationtool
GNU General Public License v3.0
115 stars 38 forks source link

Test creator XML export problem #263

Closed BrechtDeMan closed 6 years ago

BrechtDeMan commented 6 years ago

User has this error when trying to export XML from the test creator. Validation worked no problem.

TypeError: Argument 1 of XMLSerializer.serializeToString is not an object.
Stacktrace:
$s.exportXML@http://localhost/test_create/test_core.js:118:22
fn@http://localhost/js/angular.min.js line 239 > Function:4:144
e@http://localhost/js/angular.min.js:284:187
$eval@http://localhost/js/angular.min.js:148:343
$apply@http://localhost/js/angular.min.js:149:47
compile/</<@http://localhost/js/angular.min.js:284:237
dispatch@http://localhost/js/jquery-2.1.4.js:4434:15
add/elemData.handle@http://localhost/js/jquery-2.1.4.js:4121:6

I'm trying to get more background info, but perhaps this rings some bells or raises certain suspicions.

Different browsers and package as downloaded today.

othiman commented 6 years ago

see #257 and #259

othiman commented 6 years ago

Regrettably PR #259 mixed with PR #260 somehow. So either someone with the rights has to modify the PR or I have to resubmit it somehow. This github PR splitting is still a mystery for me...

othiman commented 6 years ago

OK. I was able to fix PR #259. Now it should just fix the bug described above alone.

wil-j-wil commented 6 years ago

Hey guys, I'm getting this bug too. Any advice about ways to get around it? Cheers, Will W

othiman commented 6 years ago

Hi Will, have look at pull request #259 (just click on the number). It fixes the problem. Maybe @nickjillings or @BrechtDeMan can have a look at the PR and comment or just apply it that other people do not run into the same problems.

wil-j-wil commented 6 years ago

got it. Thanks @BrechtDeMan !!

nickjillings commented 6 years ago

Hi, sorry I haven't been working on this for a while.

I'll look at your PR now @othiman and merge it in.

nickjillings commented 6 years ago

I assume @othiman your two bugs fixes this?

othiman commented 6 years ago

For me, it does.