search

BrechtDeMan / WebAudioEvaluationTool

A tool based on the HTML5 Web Audio API to perform perceptual audio evaluation tests locally or on remote machines over the web.
https://code.soundsoftware.ac.uk/projects/webaudioevaluationtool
GNU General Public License v3.0
115 stars 38 forks source link

Disable playing of samples on keypress while in comment boxes #270

Closed dw-ngcm closed 6 years ago

dw-ngcm commented 6 years ago

Uncommon issue - more drawing your attention to a quirk. References closed issue #243

When comment boxes have focus, the page still listens for keypresses and plays the corresponding samples. I have an intelligibility test using the mushra (vertical slider) interface where the listener has to type the sentence they hear in the comment box. Some sentences have letters and numbers which precludes using numbers or letters for labels as the samples get triggered by accident while participants are typing.

Workarounds: Custom two-character labels for every fragment so they can't be triggered by keyboard. Commenting out line 2420 in core.js: audioEngineContext.play(this.keys[index].audioObject.id);

nickjillings commented 6 years ago

Thanks for posting this! I have confirmed and will fix it now

nickjillings commented 6 years ago

Similar fix required to #264

nickjillings commented 6 years ago

Fixed in d510923 and pushed to all branches.

If any of the track comment boxes have focus, no key presses will alter the playing (or not playing) fragments.