search

BrechtDeMan / WebAudioEvaluationTool

A tool based on the HTML5 Web Audio API to perform perceptual audio evaluation tests locally or on remote machines over the web.
https://code.soundsoftware.ac.uk/projects/webaudioevaluationtool
GNU General Public License v3.0
114 stars 38 forks source link

spaces/tabs/end of lines #45

Open giuliomoro opened 8 years ago

giuliomoro commented 8 years ago

it'd be nice at some point (maybe immediately before the next release) to merge everything and fix once and for all tabs/spaces and LF/CRLF. Currently most files have a mix of tabs/spaces and LF/CRLF, so that different software automatically recognize the same file in a different way (e.g.: vim identifies the test-schema.xsd as [dos])

An appropriate styling shall be defined. Would you be ok with 4spaces indentation and LF end of lines ??

nickjillings commented 8 years ago

I'm happy with that, at least for now we should make our git commands have LF for end of lines and automatically convert when needed.

On tabs we should go with whatever is currently the most common for editors (I personally always use tab for indentations but obviously most editors can have this modified for tabs are 4 spaces). I personally prefer tab is tab and 4 space is 4 space, default indentations are tabs (for python which actually cares).

nickjillings commented 8 years ago

http://stackoverflow.com/questions/15958446/sourcetree-app-says-uncommitted-changes-even-for-newly-cloned-repository-what

giuliomoro commented 8 years ago

something similar I've seen for a Linux kernel repo checked out to a case-insensitive file system: there were files with same name but different casing, and, e.g.: the lowercase one was overwriting the camelCase one, or vice-versa. Real fun.

BrechtDeMan commented 8 years ago

Good idea Giulio. I also agree with Nick with regards to tabs. Though that would mean tabs for all code (XML, JS, HTML/CSS, LaTeX) except for Python? Also PHP seems to be mostly spaces in this repo. But yes all of these are currently mixed in that regard.

giuliomoro commented 8 years ago

I guess some smart editors should be able to pick up on whatever the current styling is for a given document. UNLESS there is a mix of tabs/spaces CRLF/LF in which case it may well pick the wrong style.I would be happy for spaces everywhere if that makes life easier.