Breeding-Analytics / bioflow

GNU Affero General Public License v3.0
7 stars 18 forks source link

Not using the location of the raw genotype file in pedigree QA #27

Open covaruber opened 5 months ago

covaruber commented 5 months ago

Could we make the pedQa functions work without assuming that we will have access to the original genotype file? Assuming this will not be a realistic scenario when deploying in the servers where files cannot be saved (e.g., shinyapps.io server). Could you please modify the functions to use directly the numerical code or converting back numeric code to letter for your functions (at least provisionally)? otherwise when a user saves their work and comes back that data is not available anymore. I hope that makes sense.

Cheers,

RAngelaPG commented 5 months ago

Hi Eduardo!

As I had told you before, in order not to lose real and valuable information when doing quality control, we need the original encoding of the heatmap file, but if this is not possible and we have to adapt it, I would ask you to please disable it for a while I solve it, this time it will take a considerable time, we are in harvest season and there are many analyzes to be carried out.

Best Angela

covaruber commented 5 months ago

Yes, I remember the conversation, maybe at that moment I forgot that we will not be able to save the original final in the servers. I will leave the module active for now but it means that when they come back to a new session to continue their analysis the file will not be there anymore. But yes, whenever you have time I hope we can find a way. I will try to take a look next week and see if I can help :) Still useful to keep it active for now I think. Good luck with the harvesting season Angela :)

Cheers, Eduardo


De: Angela Pacheco @.> Enviado: jueves, 25 de abril de 2024 11:16 p. m. Para: Breeding-Analytics/bioflow @.> Cc: Gio Covarrubias @.>; Author @.> Asunto: Re: [Breeding-Analytics/bioflow] Not using the location of the raw genotype file in pedigree QA (Issue #27)

Hi Eduardo!

As I had told you before, in order not to lose real and valuable information when doing quality control, we need the original encoding of the heatmap file, but if this is not possible and we have to adapt it, I would ask you to please disable it for a while I solve it, this time it will take a considerable time, we are in harvest season and there are many analyzes to be carried out.

Best Angela

— Reply to this email directly, view it on GitHubhttps://github.com/Breeding-Analytics/bioflow/issues/27#issuecomment-2077545791, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGTKGZWMVHMF45UPJ3KV6ITY7EM53AVCNFSM6AAAAABGY4Q7XWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZXGU2DKNZZGE. You are receiving this because you authored the thread.Message ID: @.***>

RAngelaPG commented 5 months ago

Yes, got it, I'll figure it out, thanks! :)